Adding support for Docmost App#685
Merged
Merged
Conversation
Create docmost-base.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create docmost-base.css to add support for the Docmost app
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Description:
Did my best to add full support for Docmost and all of its pages.
Used plex.css as the template to more naturally match colors to different parts.
A lot of buttons in the app are color coded without enough css attributes to hook into and see one type over another so those have been left for now.
I also did my best to account for the user changing the default theme in the app. Themes should work mostly the same for both Light and Dark mode.
I'm not sure what all is required for submitting something like this so just let me know if I missed anything or more information is needed.
Thanks!
Before:
After:
Benefits of this PR and context:
More apps are good and I use Docmost regularly and will do my best to keep it updated if the theming breaks.
How Has This Been Tested?
Using a self hosted instance of theme.park with the Stylus chrome app to inject the css.
Flipped between plex.css, hotline.css, and a custom community theme I made for myself.
Just went through and clicked on everything I could find to make sure the css is applied to every page, modal, and element in the app.
Everything is contained in the base.css file so shouldn't effect any functionality for anything else.
Source / References: