Skip to content

Fix qBittorrent#690

Merged
GilbN merged 2 commits into
themepark-dev:developfrom
CLHatch:develop
Jul 7, 2025
Merged

Fix qBittorrent#690
GilbN merged 2 commits into
themepark-dev:developfrom
CLHatch:develop

Conversation

@CLHatch

@CLHatch CLHatch commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Add lines under the [Preferences] heading instead of the end of the file.

Fixes #688

theme-park.dev


  • I have read the contributing guideline and understand that I have made the correct modifications

  • PR's are done against the develop branch.


Bug fixes

  • When submitting bugfixes please show a before and after screenshot of the fix, and a description of what the fix does.

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Add lines under the `[Preferences]` heading instead of the end of the file.
@CLHatch

CLHatch commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

Installing the docker mod using the :qbittorrent-hatchpatch tag works as expected. I used variables for everything, but this is in my qbittorrent.env file:

QBITTORRENT_VERSION='5.1.0'
DOCKER_MODS="${_THEMEPARK_IMAGE_?}:qbittorrent-hatchpatch"
TP_DOMAIN="${_TP_DOMAIN_?}"
TP_SCHEME="${_TP_SCHEME_?}"
TP_THEME="${_TP_THEME_?}

It is now placing the config items in the correct location, and I can verify that the theme applies. I also verified a second set wasn't added on restarting the container.

image

Add lines under the `[Preferences]` heading instead of the end of the file.

Fixes themepark-dev#657
@GilbN GilbN merged commit 394f064 into themepark-dev:develop Jul 7, 2025
@GilbN GilbN mentioned this pull request Jul 7, 2025
GilbN added a commit that referenced this pull request Jul 7, 2025
1.21.1

Fixes
#690 Fixes broken qbittorrent mod logic when sed'ing the config file.

Resolves #688
Resolves #657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants