Remove embedded per-file options in a few projects#13
Merged
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022from Aug 15, 2023
Conversation
* OpenAL: 4 source files were forcing MaxSpeed. They should instead respect the configuration they use. * xrCPU_Pipe: 1 source file (an SSE specific one with embedded asm) is forcing MaxSpeed and various preprocessor options which appear left over from when the inline assembly was being written/debugged. The config will set the appropriate optimization level. This was noticed because VerifiedDX11 is set to no optimization for debugging purposes but optimization kept being applied to certain files. * xrCore: Remove AssemblerOutput from a few files which appears to be left over from debugging. The .asm file isn't used by anything but humans.
themrdemonized
added a commit
that referenced
this pull request
Aug 15, 2023
…s-cleanup Remove embedded per-file options in a few projects (cherry picked from commit 5eefcb9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAL: 4 source files were forcing MaxSpeed. They should instead respect the configuration they use.
xrCPU_Pipe: 1 source file (an SSE specific one with embedded asm) is forcing MaxSpeed and various preprocessor options which appear left over from when the inline assembly was being written/debugged. The config will set the appropriate optimization level.
This was noticed because VerifiedDX11 is set to no optimization for debugging purposes but optimization kept being applied to certain files.
xrCore: Remove AssemblerOutput from a few files which appears to be left over from debugging. The .asm file isn't used by anything but humans.