Reduce code duplication in bone_position / bone_direction#182
Merged
themrdemonized merged 1 commit intothemrdemonized:landerfrom Apr 24, 2025
Merged
Conversation
- Both functions' bodies were identical to bone_transform save for picking out the respective component/s - Reordered bone_transform to be declared / defined first; syntactic hint that it's logically upstream of them
themrdemonized
added a commit
that referenced
this pull request
Apr 25, 2025
Reduce code duplication in bone_position / bone_direction (cherry picked from commit 94cb46f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both functions' bodies were identical to
bone_transform, save for picking out the respective component/s, so can be trivially amended to call it instead.Also reordered
bone_transformto be declared / defined first, as a syntactic hint that it's logically upstream ofbone_position/bone_direction.