Fix animated HUD FOV#199
Merged
themrdemonized merged 1 commit intothemrdemonized:landerfrom May 1, 2025
Merged
Conversation
- Separate CHUDItem getters for current and target HUD FOV / nearwall offset - Switched from interpolating base factor to interpolating final quantities - Updated CWeapon overrides accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nearwall changes inadvertently replaced HUD FOV interpolation with an interpolation on the near-wall factor, failing to cover the case where HUD FOV changes outside of nearwall.
I've removed the animation from the base factor, reinstated it on HUD FOV, added a new animated value for the positional offset, and restructured the interface as appropriate. It now exposes the animated values via dumb non-virtual getters, and their target values via virtuals, allowing
CWeaponto modify as needed without needing to know about any interpolation.