Skip to content

Don't apply rendering optimizations to cars and helicopters#271

Merged
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
OneMorePseudoCoder:all-in-one-vs2022-wpo
Jun 30, 2025
Merged

Don't apply rendering optimizations to cars and helicopters#271
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
OneMorePseudoCoder:all-in-one-vs2022-wpo

Conversation

@OneMorePseudoCoder
Copy link
Contributor

Исправляет невидимые машины (и по большей части вертолёты) при включённой оптимизации геометрии.

@themrdemonized themrdemonized merged commit b5d3114 into themrdemonized:all-in-one-vs2022-wpo Jun 30, 2025
9 of 10 checks passed
@solbjorn
Copy link

@OneMorePseudoCoder, was this purely your idea or you saw that in my fork / new upstream OGSR? It's somewhat strange you reached out to me with some interest to my code and then this PR appears.

I mean, you can take whatever you want, but I'd love to see the original authorship / credits then.
I mean, just in case. This could be just a coincidence.

@OneMorePseudoCoder
Copy link
Contributor Author

@solbjorn Oh, sorry man. Yeah, I took inspiration from your fork. I played Anomaly recently with geometry optimization turned on and noticed that all helis look messed up. I instantly remembered that you had fix to this and also that birds have optimization forcefully turned off in code. So I simply opened ai_crow.cpp file, copied some code, and pasted into Car.cpp and Helicopter.cpp.
Next time I will give you a credit even if I just take inspiration from you code.

@solbjorn
Copy link

solbjorn commented Jul 1, 2025

@OneMorePseudoCoder, ok. BTW the idea comes from the OGSR team, not me.

Also I think that in case of hierarchy visuals you don't need to traverse all the children and set optimization ignore flag for each of them (it's enough that the root visual has this flag). Have you tried just setting this flag to the base visual without iterating over the children?

themrdemonized added a commit that referenced this pull request Jan 24, 2026
Don't apply rendering optimizations to cars and helicopters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants