Skip to content

Reapply "Launchers: Cartridge Ammo + Trajectory and Reload Options" #326

Merged
themrdemonized merged 2 commits intothemrdemonized:landerfrom
Lander-Modding:shotgun-launchers
Aug 11, 2025
Merged

Reapply "Launchers: Cartridge Ammo + Trajectory and Reload Options" #326
themrdemonized merged 2 commits intothemrdemonized:landerfrom
Lander-Modding:shotgun-launchers

Conversation

@ProfLander
Copy link
Contributor

Fixes the M79 / RG6 bugs introduced in the original PR.

Summary of bug

  • Inadvertently moved CWeaponMagazinedWGrenade's ammo decrement into CWeaponGrenadeLauncher, causing it to apply to CWeaponRG6, which already defers to CWeaponShotgun for that functionality
  • As a result, M79 was trying to decrement its ammo pool twice, causing the initial launch to work, but immediately canceling all followup actions (anim, sound)
  • RG6 was doing the same, but succeeding when the ammo count was >=2; same behaviour as M79 when firing with 1 shell loaded

@ProfLander ProfLander force-pushed the shotgun-launchers branch 3 times, most recently from dcf6dbb to 1973ca5 Compare August 11, 2025 04:52
This reverts commit c172117.

2197a168bbd700f64df0fbcb5f0139a289a39102 Replace `smart_cast` with fast_dynamic_cast library
@ProfLander
Copy link
Contributor Author

Removed some CMake leftovers from the commit log; should be good now.

@themrdemonized themrdemonized changed the base branch from all-in-one-vs2022-wpo to lander August 11, 2025 11:47
@themrdemonized themrdemonized merged commit 8d89c3b into themrdemonized:lander Aug 11, 2025
9 of 10 checks passed
themrdemonized added a commit that referenced this pull request Jan 24, 2026
Reapply "Launchers: Cartridge Ammo + Trajectory and Reload Options"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants