Skip to content

Fix HDR10 issues with HUD samplers and MSAA setting#65

Merged
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
deggua:dx11-hdr10-support-hotfix-hud-sampler
Sep 4, 2024
Merged

Fix HDR10 issues with HUD samplers and MSAA setting#65
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
deggua:dx11-hdr10-support-hotfix-hud-sampler

Conversation

@deggua
Copy link
Contributor

@deggua deggua commented Sep 4, 2024

  • Fixed the HUD samplers for hud_default.s and hud_cursor.s, they were using WRAP'd sampling instead of CLAMP'd so would break with certain texture configurations expecting CLAMP'd sampling
  • Added clamp() method support to Lua shader configuration files to support this, there are others that might be useful which are commented out, but I'm hesitant to just implement them without anything using them since some of them may not work correctly, they must have been commented out for a reason, but at least the clamp option seems to work correctly
  • Force disable MSAA in DX11 if HDR is enabled since it would break the renderer if both were enabled simultaneously, this may be confusing for users without any text in the HDR option saying it's incompatible with MSAA, is there a way to provide a tooltip or something to the Modded Exe's menu that could describe this?

@themrdemonized themrdemonized merged commit 700a93f into themrdemonized:all-in-one-vs2022-wpo Sep 4, 2024
@themrdemonized
Copy link
Owner

Thanks, i'll add the tooltip warning in Modded Exe's options

themrdemonized added a commit that referenced this pull request Sep 4, 2024
Fix HDR10 issues with HUD samplers and MSAA setting

(cherry picked from commit 700a93f)
themrdemonized added a commit that referenced this pull request Sep 4, 2024
Fix HDR10 issues with HUD samplers and MSAA setting

(cherry picked from commit 700a93f)
ARandomUserN pushed a commit to ARandomUserN/xray-monolith that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants