Allow addons to hide loading tips#91
Merged
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom Oct 19, 2024
Merged
Allow addons to hide loading tips#91themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022-wpofrom
Conversation
Addons are able to customize the number of contents of loading screen tips via scripts and resource XML files, but they are not able to remove the tips altogether because empty strings are not allowed as resource strings and the engine always prints out a hardcoded tip number followed by a colon (:) anyway. With this minor change, `loadscreen.script` is able to return `0` for `get_tip_number` which will hide the loading tip altogether.
Owner
|
thanks |
themrdemonized
added a commit
that referenced
this pull request
Oct 19, 2024
Allow addons to hide loading tips (cherry picked from commit 37ae53c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addons are able to customize the number and contents of loading screen tips via scripts and XML files, but they are not able to remove the tips altogether because empty strings are not allowed as resource strings and the engine always prints out a tip number followed by a hardcoded colon character.
With this minor change,
loadscreen.scriptis able to return0forget_tip_numberwhich will hide the loading tips.Here is the best that can be done without custom binaries:

Tip number (
0) is always displayed, along with the following colon (:)The dots are coming from
ui_st_loadscreen.xmlwhere empty strings or invisible whitespace characters cannot be used.Here's the result of the same addon with binaries customized with this commit:
Minimal addon to make this work is as follows:
ui_st_loadscreen.xmlloadscreen.script