Skip to content

Bug: GrantTypeInterface not respected#1257

Merged
Sephster merged 1 commit intothephpleague:masterfrom
tobias-trozowski:bug/type-not-respected
Jan 29, 2022
Merged

Bug: GrantTypeInterface not respected#1257
Sephster merged 1 commit intothephpleague:masterfrom
tobias-trozowski:bug/type-not-respected

Conversation

@tobias-trozowski
Copy link
Copy Markdown
Contributor

when enabling a grant type via enableGrantType the provided type GrantTypeInterface is not respected ($grantType->revokeRefreshTokens($this->revokeRefreshTokens);).
A non-existent method will be called.

I just added unit test to test against a custom grant type

@tobias-trozowski tobias-trozowski changed the title GrantTypeInterface not respected Bug: GrantTypeInterface not respected Dec 23, 2021
@Sephster
Copy link
Copy Markdown
Member

I think this is related to the changes in PR #1189. If I am understanding correctly, an update to the interface to add the revokeRefreshTokens method in the next major release should fix this. Can you confirm this is what you are expecting @tobias-trozowski?

It threw me a little that your PR isn't addressing this specific issue (but thank you all the same for submitting this).

@tobias-trozowski
Copy link
Copy Markdown
Contributor Author

@Sephster i wouldn't say "expect" but adding the method would do just fine. Thank you so much!

@Sephster
Copy link
Copy Markdown
Member

Thanks @tobias-trozowski - the interface change will be added to the next major release. Thank you for the PR too

@Sephster Sephster merged commit 686b8ef into thephpleague:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants