Bug: GrantTypeInterface not respected#1257
Merged
Sephster merged 1 commit intothephpleague:masterfrom Jan 29, 2022
Merged
Conversation
10870ee to
38bb41a
Compare
Member
|
I think this is related to the changes in PR #1189. If I am understanding correctly, an update to the interface to add the It threw me a little that your PR isn't addressing this specific issue (but thank you all the same for submitting this). |
Contributor
Author
|
@Sephster i wouldn't say "expect" but adding the method would do just fine. Thank you so much! |
Member
|
Thanks @tobias-trozowski - the interface change will be added to the next major release. Thank you for the PR too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when enabling a grant type via
enableGrantTypethe provided typeGrantTypeInterfaceis not respected ($grantType->revokeRefreshTokens($this->revokeRefreshTokens);).A non-existent method will be called.
I just added unit test to test against a custom grant type