Skip to content

[8.4.x] Fix PHP 8.4 deprecation notices#1466

Merged
Sephster merged 4 commits intothephpleague:8.4.xfrom
crynobone:fix-php84-deprecations
Dec 13, 2024
Merged

[8.4.x] Fix PHP 8.4 deprecation notices#1466
Sephster merged 4 commits intothephpleague:8.4.xfrom
crynobone:fix-php84-deprecations

Conversation

@crynobone
Copy link

@crynobone crynobone commented Dec 10, 2024

This continues @Hlavtox based on #1459

@Sephster Sephster marked this pull request as ready for review December 10, 2024 10:10
@crynobone
Copy link
Author

Tests fixed: https://github.com/crynobone/oauth2-server/actions/runs/12254081422

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone
Copy link
Author

@Sephster Any changes we can merge this and make a release?

@Sephster Sephster merged commit d7471b7 into thephpleague:8.4.x Dec 13, 2024
@Sephster
Copy link
Member

Thanks @crynobone

@crynobone crynobone deleted the fix-php84-deprecations branch December 16, 2024 07:58
@crynobone
Copy link
Author

@Sephster It seems like we miss that the latest version should be based to 8.5.x, described the issue and solution here #1468

@Sephster
Copy link
Member

Sorry because the PR was against the 8.4.x branch I just released there. Will pick this up in the morning. Cheers for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants