Skip to content

Return DCError instead of BusWriteError on DC signal assertion errors #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealprof merged 2 commits into from
Feb 14, 2021
Merged

Return DCError instead of BusWriteError on DC signal assertion errors #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d892d1c
Return DCError instead of BusWriteError on DC signal assertion errors
andresovela Feb 14, 2021
f597390
Ran cargo fmt
andresovela Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Changed

- Return `DCError` instead of `BusWriteError` on errors (de-)asserting the DC signal in 8-bit GPIO interfaces

## [v0.4.0] - 2020-05-25

### Added
Expand Down
6 changes: 2 additions & 4 deletions parallel-gpio/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ where
{
fn send_commands(&mut self, cmds: DataFormat<'_>) -> Result<(), DisplayError> {
use byte_slice_cast::*;
self.dc.set_low().map_err(|_| DisplayError::BusWriteError)?;
self.dc.set_low().map_err(|_| DisplayError::DCError)?;
match cmds {
DataFormat::U8(slice) => slice.iter().try_for_each(|cmd| {
self.wr.set_low().map_err(|_| DisplayError::BusWriteError)?;
Expand Down Expand Up @@ -238,9 +238,7 @@ where

fn send_data(&mut self, buf: DataFormat<'_>) -> Result<(), DisplayError> {
use byte_slice_cast::*;
self.dc
.set_high()
.map_err(|_| DisplayError::BusWriteError)?;
self.dc.set_high().map_err(|_| DisplayError::DCError)?;
match buf {
DataFormat::U8(slice) => slice.iter().try_for_each(|d| {
self.wr.set_low().map_err(|_| DisplayError::BusWriteError)?;
Expand Down