[RFC]topology: pre-processor: support to include conf block with IncludeByKey - #9
Closed
aiChaoSONG wants to merge 1 commit into
Closed
[RFC]topology: pre-processor: support to include conf block with IncludeByKey#9aiChaoSONG wants to merge 1 commit into
aiChaoSONG wants to merge 1 commit into
Conversation
Currently, The IncludeByKey mechanism only supports to conditionally include topology conf file. Even if we only want to conditionally include a small conf block, we have to use a conf file, and in the end, we will have a lot of trivial conf files, with each only contains a small conf block. This patch extends the use of IncludeByKey, and make it support to include conf block conditionally. Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
requested review from
RanderWang,
bardliao,
juimonen,
perexg,
plbossart and
ranj063
January 17, 2023 14:03
aiChaoSONG
changed the title
lgirdwood
reviewed
Jan 18, 2023
| /* | ||
| * Check whether the value for the matched key is a conf file or conf block, | ||
| * If it ends with '.conf', it is a conf file, otherwise, it is conf block. | ||
| */ |
Member
There was a problem hiding this comment.
I would add in the comment what the supported input strings are and how they are converted to the runtime string value.
ranj063
reviewed
Jan 18, 2023
| snd_input_t *in; | ||
| snd_config_t *n; | ||
| regex_t regex; | ||
| const char *filename; |
Collaborator
There was a problem hiding this comment.
@aiChaoSONG the code looks good. Can you please add an example of this in the commit message and what the limitations are?
Collaborator
|
posted upsream alsa-project#187 |
Collaborator
|
merged upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, The IncludeByKey mechanism only supports to conditionally include topology conf file. Even if we only want to conditionally include a small conf block, we have to use a conf file, and in the end, we will have a lot of trivial conf files, with each only contains a small conf block.
This patch extends the use of IncludeByKey, and make it support to include conf block conditionally.
Signed-off-by: Chao Song chao.song@linux.intel.com