Config: Add DCblock to TGL, TGL-H, MTL, and LNL - #177
Merged
Conversation
singalsu
marked this pull request as ready for review
September 4, 2023 13:31
singalsu
requested review from
andrula-song,
btian1,
cujomalainey,
kv2019i and
lgirdwood
September 4, 2023 13:31
btian1
reviewed
Sep 5, 2023
btian1
left a comment
btian1
left a comment
There was a problem hiding this comment.
I am ok to add it to mtl and lnl, for tgl, this is developed platform, shall we add as well? or there is a requirement?
Contributor
|
@singalsu Needs rebase now that DRC is merged. |
This patch enables load of the DC blocker component. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
config_dcblock
branch
from
September 5, 2023 10:51
66dd8bc to
1493b30
Compare
Contributor
Author
Thanks! It's fixed now. |
Contributor
Author
I plan to check and propose to change the IIR in HDA analog capture to dcblock so it would apply to all current sof-hda-generic platforms. There is no gain boost need for analog and also the DC pulse in capture start and when pressing headset buttons can be handled by dccomp (a simple 1st order IIR). It saves almost 5 MCPS if the filtering capability is sufficient. |
kv2019i
approved these changes
Sep 5, 2023
lgirdwood
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables load of the DC blocker component.