Skip to content

Config: Add RTC_AEC to TGL. TGL-H, and LNL - #183

Closed
singalsu wants to merge 1 commit into
thesofproject:mainfrom
singalsu:add_rtc_aec_other
Closed

Config: Add RTC_AEC to TGL. TGL-H, and LNL#183
singalsu wants to merge 1 commit into
thesofproject:mainfrom
singalsu:add_rtc_aec_other

Conversation

@singalsu

@singalsu singalsu commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

This patch adds same RTC_AEC module entry as added earlier to config/mtl.toml. The purpose is enable testing the component in other platforms.

This patch adds same RTC_AEC module entry as added earlier
to config/mtl.toml. The purpose is enable testing the component
in other platforms.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu
singalsu marked this pull request as ready for review October 4, 2023 16:33
@kv2019i

kv2019i commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Please resubmit directly to SOF repo (rimage moved to sof/tools/rimage).

@kv2019i kv2019i closed this Oct 11, 2023
@kv2019i

kv2019i commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Ok, let me keep this open still

@kv2019i kv2019i reopened this Oct 11, 2023

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave -1 instead , please submit to SOF main

@yongzhi1

Copy link
Copy Markdown

With RTC_AEC added, it can give people impression that the module is part of the FW build now.

@marc-hb

marc-hb commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

@singalsu you can very easily move these commits to the main sof repo, see how at:

@singalsu

singalsu commented Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

With RTC_AEC added, it can give people impression that the module is part of the FW build now.

There is no worry, the Kconfig is "default n", so there is no risk that a mock-up feature would end up to build by default. I think we should have rimage toml for everything. Then including component to build is just kconfig change. Otherwise there's a big patching effort find out and add all the toml files details.

@singalsu

Copy link
Copy Markdown
Contributor Author

New patch is in thesofproject/sof#8315

@singalsu singalsu closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants