audio: dai-zephyr: update channel verification logic - #8760
Conversation
716cce2 to
76aa374
Compare
This commit updates the channel verification logic in dai-zephyr.c. The previous condition checked for an exact match between hw_params.channels and params->channels. The new condition allows for hw_params.channels to be greater than or equal to params->channels, providing more flexibility in channel configuration. Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
76aa374 to
cd00456
Compare
|
There are some build failures. Can you please check? https://github.com/thesofproject/sof/actions/runs/7581488658/job/20649189700?pr=8760 |
I've noticed that the Zephyr / build-linux for (zmain, lnl/tgl/mtl) is failing on various PRs as well – the reason is unclear. |
|
@dbaluta @dnikodem The mainlin Zephyr fails are known and related to this interface change (zephyrproject-rtos#32 , #7593 and zephyrproject-rtos/zephyr#64755 ). |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Some concern how this impacts cases where the DAI really only supports a specific fixed channel count.
Could the existing mechanism to use 0 to signal that the DAI driver can support a variable property, be used here instead of this patch?
| } | ||
|
|
||
| if (hw_params.channels && hw_params.channels != params->channels) { | ||
| if (hw_params.channels && hw_params.channels < params->channels) { |
There was a problem hiding this comment.
Hmm, with some DAI implementations (like Intel PCH dmic), the channel count really is fixed, so the old check is correct. But it's true if this constrained cannot be assume to hold for all DAIs, we can enforce the condition here. DAI specific checks needs to return failure later.
There was a problem hiding this comment.
@dnikodem might be worth an inline comment here to explain. Also it might be worth a
switch (dai_type) {
case dynamic_dai:
// compare using new flow
break;
default:
// compare using old flow for fixed dais.
break;
}There was a problem hiding this comment.
Colleagues, after reading your comments, I'm not sure if my change is correct – I'm working on confirming my doubts. Thanks for the feedback
|
After further analysis of the code and feedback from Liam and Kai, I have concluded that this condition may remain unchanged. Therefore, I am closing this pull request. Thank you. |
6 participants
This commit updates the channel verification logic in dai-zephyr.c. The previous condition checked for an exact match between hw_params.channels and params->channels.
The new condition allows for hw_params.channels to be greater than or equal to params->channels, providing more flexibility in channel configuration.