Do not pin to minor Go versions in go.mod#588
Merged
rdimitrov merged 1 commit intotheupdateframework:masterfrom Jan 30, 2024
Merged
Do not pin to minor Go versions in go.mod#588rdimitrov merged 1 commit intotheupdateframework:masterfrom
rdimitrov merged 1 commit intotheupdateframework:masterfrom
Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
=========================================
Coverage ? 71.43%
=========================================
Files ? 10
Lines ? 2013
Branches ? 0
=========================================
Hits ? 1438
Misses ? 463
Partials ? 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
kommendorkapten
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe we bumped this because of a scanning tool check(govulncheck) that was quite annoying and insisted on upgrading the minor version.
In any case, I think it's better to not enforce other users of the library pin their minor version too just because of us.