move testutils under an ./internal/ directory

[mikedanese]

This prevents these libraries from being depended on from outside the module.

[rdimitrov]

@mikedanese - there's some things to fix so we can satisfy the CI but I agree it's better if these packages are internal 👍 Thanks for addressing this 🙏

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a2b819) 70.18% compared to head (a1b3a1f) 70.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          10       10           
  Lines        2123     2123           
=======================================
  Hits         1490     1490           
  Misses        517      517           
  Partials      116      116           

Flag	Coverage Δ
Go-1.21	70.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikedanese]

Oops, fixed.

[codysoyland]

FWIW, I was looking at using the RepositorySimulator in testutils as part of sigstore-go's test suite, but I can understand why it's probably best to keep it internal.

[rdimitrov]

@codysoyland - oh, I wasn't aware of that, thanks 👍 Given this I think it's okay to leave it as a standalone package. cc: @mikedanese

edit:
@codysoyland - hey, I just saw you mentioned in the PR that eventually you came up with another workaround for the tests. I don't think there's anyone else trying to use the testutils package so far, but I'm supportive of leaving it visible if it's going to help sigstore-go with the testing.

Of course, at the end we can always revisit and move it out of internal if someone comes up with a valid use case for it 👍

[codysoyland]

edit: @codysoyland - hey, I just saw you mentioned in the PR that eventually you came up with another workaround for the tests. I don't think there's anyone else trying to use the testutils package so far, but I'm supportive of leaving it visible if it's going to help sigstore-go with the testing.

Of course, at the end we can always revisit and move it out of internal if someone comes up with a valid use case for it 👍

@rdimitrov Thanks for offering to keep it visible, but I decided late yesterday that it makes sense for us to have our own stripped down version of a repo simulator and not depend on the one here, since it may diverge and become incompatible, so I'm supportive of going ahead and merging this one!

[rdimitrov]

@codysoyland - Thanks! 😃👍

@mikedanese - There's a few conflicts you have to fix, but otherwise we should be good to go then 👍

[mikedanese]

Rebased.

[rdimitrov]

The failing CI job is not related to the changes in this PR (tries to run go 1.22 and apparently something is not supporting it yet).