fix: use SHA384 for ECDSA P384#629
Merged
rdimitrov merged 2 commits intotheupdateframework:masterfrom Apr 2, 2024
Merged
Conversation
Signed-off-by: mrjoelkamp <joel.kamp@docker.com>
mrjoelkamp
force-pushed
the
fix-use-sha-384-for-ecdsa-p384
branch
from
c735675 to
5fe820a
Compare
rdimitrov
approved these changes
Apr 2, 2024
Contributor
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
IIRC this was done this way as technically the spec did not list any other key schemes, but in any case it's good to support more 👍
Thanks! @mrjoelkamp 🚀
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 70.51% 72.94% +2.43%
==========================================
Files 10 10
Lines 2123 1656 -467
==========================================
- Hits 1497 1208 -289
+ Misses 505 327 -178
Partials 121 121 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle hash algorithm selection for
ecdsa-sha2-nistp384fixes #628