fix: multirepo potential nil pointer dereference#658
Merged
kommendorkapten merged 1 commit intotheupdateframework:masterfrom Nov 20, 2024
Merged
Conversation
Member
|
Thanks for fixing this. Would you mind amend the commit with a signoff? |
MrDan4es
force-pushed
the
multirepo_nil_pointer_repo
branch
from
31f7051 to
59b3c0d
Compare
Contributor
Author
|
Done |
rdimitrov
reviewed
Nov 20, 2024
Signed-off-by: mrdan4es <mrdan4es@gmail.com>
MrDan4es
force-pushed
the
multirepo_nil_pointer_repo
branch
from
59b3c0d to
f0cdc4f
Compare
rdimitrov
approved these changes
Nov 20, 2024
Contributor
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
This looks nice! 🙌 Thank you 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevent potential panic on NIL pointer when we trying to download file (from user input repo name for example).