Skip to content

Allow users to configure retry behavior in DefaultFetcher#684

Merged
kommendorkapten merged 9 commits intotheupdateframework:masterfrom
malancas:fetcher-request-retry
Apr 24, 2025
Merged

Allow users to configure retry behavior in DefaultFetcher#684
kommendorkapten merged 9 commits intotheupdateframework:masterfrom
malancas:fetcher-request-retry

Conversation

@malancas
Copy link
Copy Markdown
Contributor

@malancas malancas commented Apr 16, 2025

Related to #660

Follow up to #682. This adds retry configuration to the DefaultFetcher#DownloadFile method. It uses github.com/cenkalti/backoff to configure retry behavior. I added additional DefaultFetcher and UpdaterConfig setters for:

  • custom retry interval and retry count
  • any number of backoff.RetryOptions as specified in the backoff library

malancas added 3 commits April 9, 2025 12:05
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas malancas changed the title Fetcher request retry Allow users to configure retry behavior in DefaultFetcher Apr 16, 2025
@malancas malancas marked this pull request as ready for review April 16, 2025 17:29
@malancas malancas requested a review from a team as a code owner April 16, 2025 17:29
Signed-off-by: Meredith Lancaster <malancas@github.com>
Copy link
Copy Markdown
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🚀

@kommendorkapten kommendorkapten merged commit e9e0d48 into theupdateframework:master Apr 24, 2025
23 checks passed
@kommendorkapten kommendorkapten mentioned this pull request May 6, 2025
@malancas malancas deleted the fetcher-request-retry branch May 28, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants