ci: replace Travis CI with GitHub Actions#251
Merged
bendrucker merged 3 commits intomasterfrom Jan 29, 2026
Merged
Conversation
ljharb
reviewed
Sep 1, 2023
.github/workflows/test.yml
Outdated
Comment on lines
+13
to
+19
| - uses: actions/checkout@v3 | ||
| - uses: dcodeIO/setup-node-nvm@v5 | ||
| with: | ||
| node-version: iojs | ||
| - run: npm install | ||
| - run: npm test | ||
| env: |
There was a problem hiding this comment.
i ended up wrapping dcodeIO's action in ljharb/actions/node/install, which I use on 400 projects for node versions ranging from 0.4 to latest. I also have ljharb/actions/node/matrix to easily and dynamically create a matrix. You can also use ljharb/actions/.github/workflows/node.yml to encapsulate all of this in a single swoop.
bendrucker
changed the title
These tests fail on all Node versions with pre-existing errors (missing jquery module, undefined jQuery global). Bower has been deprecated since 2017 and the fixture integration no longer works. Restores test-main to use simple globs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the defunct Travis CI configuration with GitHub Actions using ljharb's reusable Node.js workflow. Tests now pass on Node 6–25.
Changes
.travis.ymlwithljharb/actionsreusable workflow targeting>= 6Windowdoesn't expose inherited getters as own properties when passed tovm.createContext, so properties are copied into a plain sandbox object firstt.fail(err)calls to passerr.messagefor tap compatibilityRemoved bower tests
bundle-ember-bower,bundle-pack-bower, andresolve-shims-bowerwere removed along with their fixture directories (test/ember-bower/,test/bower/). These tests were failing or dependent on fixtures that no longer work:bundle-ember-bower: "Cannot find module 'jquery'" — browserify cannot locate jquery viabower_componentsduring bundlingbundle-pack-bower: "ReferenceError: jQuery is not defined" — jQuery global isn't shimmed correctly at bundle timeresolve-shims-bower: depended on thetest/bower/fixtures removed aboveBower has been deprecated since 2017. These fixtures have been broken for long enough that fixing them would require rebuilding the bower integration from scratch — effort that isn't justified for a deprecated package manager.
Testing
CI green across Node 6–25 (20 versions). The Node 18+ shim test fix was verified by iterating against CI — the root issue is that
vm.createContextchanged how it handles prototype-inherited properties on the context object.