Skip to content

Fix #34 - Make the plugin compatible with flake8 3.5.0.#35

Merged
tholo merged 1 commit into
tholo:masterfrom
jezdez:flake8-3.5.0
Oct 23, 2017
Merged

Fix #34 - Make the plugin compatible with flake8 3.5.0.#35
tholo merged 1 commit into
tholo:masterfrom
jezdez:flake8-3.5.0

Conversation

@jezdez

@jezdez jezdez commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Fixes #34 but it needs #24 as well to make the tests pass for me locally.

@Serozd

Serozd commented Oct 23, 2017

Copy link
Copy Markdown

@tholo please merge this and bump version

@ktdreyer

Copy link
Copy Markdown
Contributor

I've tested this in my project and it works for me. Thanks @jezdez !

@lk-geimfari

Copy link
Copy Markdown

@jezdez Seems like maintainer of this project in offline from 2016 year. I suggest to fork it and publish with new name. What do you think?

@jezdez

jezdez commented Oct 23, 2017

Copy link
Copy Markdown
Contributor Author

Folks, please pin your versions properly and let the maintainer merge whenever they have time.

Here is what you'd need in your requirements file:

flake8<3.5.0
pytest-flake8==0.8.1

There is no need to fork this project just to get this fix out of the door.

@mikenerone

Copy link
Copy Markdown

@jezdez I don't think @lk-geimfari was proposing to fork it simply for the purpose of getting this fix "out the door". He correctly observed that the maintainer hasn't closed or even commented on an issue report, or made a commit on this project, for just over a year now. Why do you feel confident this will be addressed?

@lk-geimfari

lk-geimfari commented Oct 23, 2017

Copy link
Copy Markdown

@mikenerone Absolutely right. This is what I had in mind.

@tholo tholo merged commit d82cafa into tholo:master Oct 23, 2017
@jezdez jezdez deleted the flake8-3.5.0 branch October 24, 2017 07:04
@jezdez

jezdez commented Oct 24, 2017

Copy link
Copy Markdown
Contributor Author

@tholo Thank you for the quick merge, we appreciate you taking the time.

Despite the differences in this thread here, we do owe you for creating this package. Thank you. ❤️

@ktdreyer

Copy link
Copy Markdown
Contributor

@tholo thank you for merging this and especially for tagging 0.9 and pushing that to PyPI. That was fast!

@mikenerone

Copy link
Copy Markdown

Indeed, don't get me wrong - I love this helpful plugin, and I'm ecstatic that you materialized to take care of business here, @tholo. Kinda like Batman. Hopefully all is well and we'll see you around more.

dahlia added a commit to dahlia/nirum-python that referenced this pull request Oct 29, 2017
dahlia added a commit to nirum-lang/nirum-python-wsgi that referenced this pull request Nov 24, 2017
As tholo/pytest-flake8#35 was merged and
released as 0.9.1.
earlbread added a commit to earlbread/nirum-python-http that referenced this pull request Mar 3, 2018
earlbread added a commit to earlbread/nirum-python-http that referenced this pull request Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants