fix/batch-2026-03-28 - #78
Merged
Merged
Conversation
… target Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Jun 4, 2026
thomasluizon
added a commit
that referenced
this pull request
Jun 4, 2026
…on (#78) Consolidate the duplicated 2x2 (interval x isBrazil) price-ID switches from CreateCheckoutCommandHandler and GetPlansQueryHandler behind a single IPriceResolver seam, so the mapping lives in exactly one place. Add fail-fast startup validation (StripeSettings.ValidatePriceIds) wired into ValidateOrbitSecuritySettings so the API refuses to boot when any of the four BRL/USD monthly/yearly price IDs is blank. Add unit tests for the resolver and the validation, plus BR and non-BR integration tests covering checkout price resolution and plans currency end-to-end with a faked IBillingService. Refs thomasluizon/orbit-ui-mobile#78 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thomasluizon
added a commit
that referenced
this pull request
Jun 4, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thomasluizon
added a commit
that referenced
this pull request
Jun 5, 2026
…on (#78) Consolidate the duplicated 2x2 (interval x isBrazil) price-ID switches from CreateCheckoutCommandHandler and GetPlansQueryHandler behind a single IPriceResolver seam, so the mapping lives in exactly one place. Add fail-fast startup validation (StripeSettings.ValidatePriceIds) wired into ValidateOrbitSecuritySettings so the API refuses to boot when any of the four BRL/USD monthly/yearly price IDs is blank. Add unit tests for the resolver and the validation, plus BR and non-BR integration tests covering checkout price resolution and plans currency end-to-end with a faked IBillingService. Refs thomasluizon/orbit-ui-mobile#78 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thomasluizon
added a commit
that referenced
this pull request
Jun 5, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thomasluizon
added a commit
that referenced
this pull request
Jun 5, 2026
…on (#78) (#177) * refactor(api): consolidate Stripe price resolution + startup validation (#78) Consolidate the duplicated 2x2 (interval x isBrazil) price-ID switches from CreateCheckoutCommandHandler and GetPlansQueryHandler behind a single IPriceResolver seam, so the mapping lives in exactly one place. Add fail-fast startup validation (StripeSettings.ValidatePriceIds) wired into ValidateOrbitSecuritySettings so the API refuses to boot when any of the four BRL/USD monthly/yearly price IDs is blank. Add unit tests for the resolver and the validation, plus BR and non-BR integration tests covering checkout price resolution and plans currency end-to-end with a faked IBillingService. Refs thomasluizon/orbit-ui-mobile#78 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): exempt local Development from Stripe price-ID validation (#78) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined Changes
This PR bundles the following worktree branches:
Changes
Habit.SkipFlexible()creates a HabitLog with Value=0HabitScheduleServicesubtracts skips from period targetGetHabitScheduleQueryreturns adjustedflexibleTargetBulkSkipHabitsTool(usedAdvanceDueDateinstead ofAdvanceDueDatePastWindow)Test Plan
🤖 Generated with Claude Code