Skip to content

Don't overwrite LangVersion if set and check raise diagnostic error if level not high enough #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 22, 2025
Merged

Don't overwrite LangVersion if set and check raise diagnostic error if level not high enough #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8a90c6
Don't overwrite LangVersion if set and check raise diagnostic error i…
thomhurst May 22, 2025
b740a1a
Fix
thomhurst May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions TUnit.Core.SourceGenerator/CodeGenerators/LanguageVersionCheckGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;

namespace TUnit.Core.SourceGenerator;

[Generator]
public class LanguageVersionCheckGenerator : IIncrementalGenerator
{
public void Initialize(IncrementalGeneratorInitializationContext context)

@Youssef1313 Youssef1313 Jan 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like this shouldn't be a source generator at all. It should instead be a diagnostic analyzer.

{
var settings = context.CompilationProvider
.Select((c, _) =>
{
LanguageVersion? csharpVersion = c is CSharpCompilation comp
? comp.LanguageVersion
: null;

return csharpVersion;
});

context.RegisterSourceOutput(settings, static (sourceProductionContext, languageVersion) =>
{
if (languageVersion is null)
{
return;
}

if((int)languageVersion.Value < 1200)
{
sourceProductionContext.ReportDiagnostic(Diagnostic.Create(
new DiagnosticDescriptor(
"TUNIT_LANG_001",
"Language Version Check",
"TUnit requires C# 12 or higher when using Source Generation.",
"Usage",
DiagnosticSeverity.Error,
true),
Location.None));
}
});
}
}
1 change: 0 additions & 1 deletion TUnit.Engine/TUnit.Engine.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
<TestingPlatformShowTestsFailure>true</TestingPlatformShowTestsFailure>
<TestingPlatformCaptureOutput>false</TestingPlatformCaptureOutput>
<LangVersion>latest</LangVersion>
<OutputType>Exe</OutputType>
<GenerateProgramFile>false</GenerateProgramFile>
</PropertyGroup>
Expand Down
8 changes: 6 additions & 2 deletions TUnit.Engine/TUnit.Engine.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>


<PropertyGroup>
<LangVersion Condition="'$(LangVersion)' == ''">latest</LangVersion>
</PropertyGroup>

<ItemGroup Condition="'$(TUnitImplicitUsings)' == 'true'">
<Using Include="TUnit.Core" />
</ItemGroup>
Expand All @@ -13,4 +17,4 @@
<AssemblyMetadata Include="TUnitReflectionScanner" Value="true" />
</ItemGroup>

</Project>
</Project>
4 changes: 4 additions & 0 deletions TUnit.TestProject.VB.NET/TUnit.TestProject.VB.NET.vbproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<Import Project="..\TestProject.props" />

<PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion TUnit/TUnit.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
<TestingPlatformShowTestsFailure>true</TestingPlatformShowTestsFailure>
<TestingPlatformCaptureOutput>false</TestingPlatformCaptureOutput>
<LangVersion>latest</LangVersion>
<OutputType>Exe</OutputType>

@Youssef1313 Youssef1313 Jan 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your PR. But setting OutputType in NuGet props/targets is very bad and should NOT be done. It should be on the user to set this.

</PropertyGroup>

Expand Down
4 changes: 4 additions & 0 deletions TUnit/TUnit.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>

<PropertyGroup>
<LangVersion Condition="'$(LangVersion)' == ''">latest</LangVersion>
</PropertyGroup>

<ItemGroup Condition="'$(TUnitImplicitUsings)' == 'true'">
<Using Include="TUnit.Core" />
<Using Include="TUnit.Core.HookType" Static="True" />
Expand Down