chore(deps): update dependency polyfill to v11#6418
Conversation
Up to standards ✅🟢 Issues
|
Review:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e37e90012a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <!-- Auto-include Polyfill package for compile-time type generation --> | ||
| <PropertyGroup> | ||
| <_TUnitPolyfillVersion>10.11.2</_TUnitPolyfillVersion> | ||
| <_TUnitPolyfillVersion>11.0.0</_TUnitPolyfillVersion> |
There was a problem hiding this comment.
Do not force Polyfill 11 onto downlevel consumers
For netstandard/.NET Framework projects that do not explicitly reference Polyfill, this target now silently injects Polyfill 11.0.0 into their compilation. Polyfill 11 changes the downlevel Process.Run/RunAsync string overloads by inserting a bool silent parameter before the existing timeout/cancellation parameter, so existing TUnit consumers that compile today with the auto-injected 10.x source and call those overloads positionally (for example passing a TimeSpan or CancellationToken as the third argument) will fail to compile or bind differently just by upgrading TUnit. Since this is a hidden transitive source package rather than an explicit user dependency, keep the auto-injected version on the 10.x line unless TUnit is intentionally shipping that source-breaking change.
Useful? React with 👍 / 👎.
e37e900 to
9a3db28
Compare
Code reviewNo issues found. This is a trivial, correct dependency bump: |
9a3db28 to
a58a637
Compare
Code reviewNo issues found. This remains a minimal, correct dependency bump: Re-checked the inconsistency flagged in an earlier review comment on this PR ( CI checks are still in progress (no failures so far); recommend waiting for them to go green before merging. Checked for bugs and CLAUDE.md compliance. |
This PR contains the following updates:
10.11.2→11.0.0Release Notes
SimonCropp/Polyfill (Polyfill)
v11.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.