This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Update dependencies 15-09-2020#458
Closed
veado wants to merge 2 commits into
Closed
Conversation
veado
added a commit
that referenced
this pull request
Sep 16, 2020
to avoid issues we have had in #458
Collaborator
Author
|
We will give another try when |
veado
added a commit
that referenced
this pull request
Sep 16, 2020
to avoid issues we have had in #458. - [x] Remove `fp-ts` dependency. It's already provided by `@devexperts/remote-data-ts` and might cause issues using different versions of `fp-ts`. - [x] Remove misc. `eslint` packages which are already provided by `react-scripts`. It might cause issues while having different versions of these packages. - [x] Bump to 0.0.3-alpha.1
luxuereal
added a commit
to luxuereal/wallet-Asgardex-electron
that referenced
this pull request
Jun 16, 2023
to avoid issues we have had in thorchain/asgardex-electron#458. - [x] Remove `fp-ts` dependency. It's already provided by `@devexperts/remote-data-ts` and might cause issues using different versions of `fp-ts`. - [x] Remove misc. `eslint` packages which are already provided by `react-scripts`. It might cause issues while having different versions of these packages. - [x] Bump to 0.0.3-alpha.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
This update failed due several dependency issues and will be postponed until
react-scriptssupportstypescript@4Available updates
Issues
(1)
typescript@4.xis not fully supported by latestreact-scripts@3.4.3(react/create-react-app#9515). It causeseslintissues and needs to be updated to latest@typescript-eslint/eslint-plugin@4.xbefore. This needed change is already in master (react/create-react-app#9434), but not published yet.(2)
testcafedoes not supportelectron@10.x. we will still stick withelectron@9.x.(3) Update to latest
fp-ts@2.8.2failed, it introduces type errors by using@devexperts/remote-data-ts@2.0.4^ These errors are very similar as described in devexperts/remote-data-ts#49
Due lack of time we will stick on
fp-ts@2.8.1for now.