docs: fix build-selection table in requirements - #37
Merged
Conversation
The table mapped the netstandard2.0 build to app types (WPF/console), implying desktop apps miss out. NuGet selects by target framework: a WPF app on net10.0-windows gets the net10.0 build. Only .NET Framework falls back to netstandard2.0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #36, before
v2.1.3is tagged and published.The requirements table mapped the
netstandard2.0build to app types ("keeps WPF/console apps lean"), which reads as if desktop apps were excluded from the modern builds. That is wrong: NuGet selects by target framework, so a WPF app onnet10.0-windowsgets the fullnet10.0build — as the WPF sample in this repo does. Only .NET Framework falls back tonetstandard2.0.Changes:
-windowsvariants named explicitly.release-notes/v2.1.3.mdextended with this fix. No version bump —v2.1.3is not tagged yet, so this still belongs to it.Docs only, no code touched.