This repository was archived by the owner on Mar 21, 2020. It is now read-only.
Closed
Conversation
added 2 commits
June 6, 2018 10:50
At Poll Everywhere, we've found that 1.3 messages per minute is a more reasonable setting for FOMO events. Also increasing the debounce from 20 to 30 because the former was judged to be too frequent.
Contributor
|
I like the party changes! And yes I'm sure the env numbers are very company specific. In exchange for this PR, it would be nice to have the messaging be an ENV too. Then companies can adjust all these settings to their liking. I no longer work at Thoughtbot though so I can't merge this or maintain this repo. |
Author
|
FYI, a couple points you might be interested in:
Thanks for writing this wonderful bot. |
Author
That's a good idea. If I have time I'll submit that as a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is worthy of a PR, so please close if you're satisfied with the existing defaults.
Poll Everywhere has found these settings to be more useful. If thoughtbot is using the default
envvalues then it's probably a big company vs. small company thing.@heremakes the notifications more useful. Most Poll Evians are already in the rooms that FOMObot is watching, so they already receive the normal notifications.@heregrabs their attention which is what we want.