Update factory_bot_rails.gemspec#479
Closed
JuanVqz wants to merge 1 commit into
Closed
Conversation
I am currently in the process of upgrading from Ruby 2.6 to Ruby 3.0. Initially, I didn't find any restrictions on updating my current factory_bot_rails version to the latest one. Unfortunately, this turned out to be incorrect. The latest version of factory_bot_rails requires factory_bot v6.4, which in turn requires Ruby 3, causing my update to fail. ``` SyntaxError: /root/project/vendor/bundle/ruby/2.6.0/gems/factory_bot-6.4.5/lib/factory_bot/evaluator.rb:38: syntax error, unexpected ... ...method_missing(method_name, ...) ``` So, adding the `required_ruby_version` might help to prevent the misconception. References: - thoughtbot/factory_bot#1614 - thoughtbot/factory_bot@36bd065 - https://github.com/thoughtbot/factory_bot/pull/1622/files
Member
|
I see this was already introduced at #510 - I'm sorry that PR was merged instead of yours, even though yours was opened first. |
Author
Thanks for merging the fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently in the process of upgrading from Ruby 2.6 to Ruby 3.0. Initially, I didn't find any restrictions on updating my current factory_bot_rails version to the latest one. Unfortunately, this turned out to be incorrect. The latest version of factory_bot_rails requires factory_bot v6.4, which requires Ruby 3, causing my update to fail.
So, adding the
required_ruby_versionmight help to prevent the misconception.References:
>= 2.5.0factory_bot#1614