Skip to content

Support for MSVC 2013#182

Closed
cboulay wants to merge 5 commits into
thp:masterfrom
psmoveservice:msvc
Closed

Support for MSVC 2013#182
cboulay wants to merge 5 commits into
thp:masterfrom
psmoveservice:msvc

Conversation

@cboulay
Copy link
Copy Markdown
Contributor

@cboulay cboulay commented Jul 14, 2015

First 2 commits are the same as in #180.
This supercedes #163

cboulay added 2 commits July 13, 2015 22:56
…oved OpenCV searching/installing, instead rely on cmake find_package. Tested in Windows Mingw64-32 bit, Ubuntu local and system OpenCV, OSX local and system OpenCV.
@cboulay cboulay force-pushed the msvc branch 2 times, most recently from f0aced2 to 95d4bc9 Compare July 15, 2015 20:06
cboulay added 3 commits July 20, 2015 23:23
… Also

switched libusb to a submodule. Note that the MSVC build currently does
not work with OpenCV3 whereas all other builds do.
@cboulay
Copy link
Copy Markdown
Contributor Author

cboulay commented Aug 7, 2015

I'm in the process of updating this to have a smaller footprint similar to @PolyarcGames changes here.
Edit: Had the wrong link.

@thp
Copy link
Copy Markdown
Owner

thp commented Dec 3, 2015

Any updates here?

@cboulay
Copy link
Copy Markdown
Contributor Author

cboulay commented Dec 4, 2015

I haven't looked at this in a while and I don't really have the time to do it now.

It's become a bit of a nightmare because there have been some changes to your repo since I started the process and there were some non-MSVC-specific changes that crept into my working branch. Some of which conflicted with what you had. I attempted to rebase -i and ended up with the same commits being done over and over. You can see that here.

I don't blame you for not wanting to pull that. Making a new branch that has ONLY the msvc-related changes will take me several hours and I don't have that kind of time these days. Someone else is welcome to reproduce only the necessary changes based off my work linked above.

@thp
Copy link
Copy Markdown
Owner

thp commented Jan 8, 2016

Closing in favor of #190.

@thp thp closed this Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants