Skip to content

Improve Python build, examples, and docs#337

Merged
thp merged 5 commits into
thp:masterfrom
nitsch:improve-python
Dec 16, 2017
Merged

Improve Python build, examples, and docs#337
thp merged 5 commits into
thp:masterfrom
nitsch:improve-python

Conversation

@nitsch
Copy link
Copy Markdown
Collaborator

@nitsch nitsch commented Dec 15, 2017

This should fix a couple of problems people were having with Python bindings (see #328 and #335 for example). Also some documentation that we can refer to (and hopefully build upon).

This sets a version number in the find_package() call that looks for the
Python lib. Useful if multiple versions of the lib are installed and the
user wants CMake to find a particular one of them.

In its most basic form, this can be used to select between Python 2 and
3 (simply set the option to 2 or 3, respectively). But minor versions
are also supported (e.g. 2.7 vs. 2.6).

Leaving it unset (the default) makes CMake behave the same way as
before.
Copy link
Copy Markdown
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@thp thp merged commit cd194fe into thp:master Dec 16, 2017
@nitsch nitsch deleted the improve-python branch December 16, 2017 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants