Fix Windows build of Java and Processing bindings#343
Merged
Conversation
The cp command was not understood by the Windows CMD, so this only worked on Linux and OSX. CMake's -E copy command does not support wildcards in filenames either, so the most robust way is to simply call a script for copying on Windows.
The .jar file needs to be created only after SWIG generated the .java files. This was not working properly.
Windows does not use the "lib" prefix for its libraries by default. Only MinGW does that.
thp
approved these changes
Dec 29, 2017
Owner
thp
left a comment
thp
left a comment
There was a problem hiding this comment.
this is okay. the batch file solution is not as nice as could be, but it's good for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build was broken on Windows using Visual Studio.