fix: storage.get return None instead of raise the NoSuchKey error#161
Merged
Bladrak merged 1 commit intothumbor-community:masterfrom Aug 18, 2025
Conversation
Author
|
Pipeline is failing because it takes too long to install the dependencies |
|
@brambaud thanks, if you can rebase CI should be fixed |
Tested Thumbor 7.7.4, when `STORAGE = 'tc_aws.storages.s3_storage'` it crashes due to a botocore.errorfactory.NoSuchKey error. Also become a little bit more consistent with result storage's get method which does the same.
brambaud
force-pushed
the
fix/storage-get-error-when-image-does-not-exist
branch
from
daa8ca5 to
9052f79
Compare
Author
|
Done |
Bladrak
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested Thumbor 7.7.4, when
STORAGE = 'tc_aws.storages.s3_storage'it crashes due to abotocore.errorfactory.NoSuchKeyerror.Also become a little bit more consistent with result storage's get method which does the same.