fix(cli): hide windows console windows for runner/claude subprocesses - #242
Merged
Merged
Conversation
Prevent transient cmd window popups on Windows by enabling windowsHide in detached runner spawns and Claude SDK child process spawns. Add regression tests for spawnHappyCLI windowsHide behavior across win32 and non-win32 cases.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jasonczc
pushed a commit
to jasonczc/haqi
that referenced
this pull request
Mar 15, 2026
…tiann#242) (cherry picked from commit 55f08bd)
SeeFlowerX
pushed a commit
to SeeFlowerX/hapi
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cd cli && bunx vitest run src/utils/spawnHappyCLI.test.tscd cli && bun run typecheck