perf: use a shared resty.Client object for all requests#628
Closed
kamilon wants to merge 2 commits intotibiadata:mainfrom
Closed
perf: use a shared resty.Client object for all requests#628kamilon wants to merge 2 commits intotibiadata:mainfrom
kamilon wants to merge 2 commits intotibiadata:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should actually make a noticeable difference in resource usage at TibiaData scale. Back of the napkin math is somewhere around 10MB less GC churn and 10-15% reduced CPU. It should also lower average response time from Tibia.com due to reduced TLS handshakes with the service.
I validated this via build, test and race detector. I also double checked that resty.Client is thread-safe.