Skip to content

perf: avoid LoadLocation syscall for each TibiaDataDatetime call #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamilon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: avoid LoadLocation syscall for each TibiaDataDatetime call #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/TibiaDataUtils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ import (
"golang.org/x/text/unicode/norm"
)

// berlinLocation is cached to avoid repeated time.LoadLocation calls per request.
var berlinLocation, _ = time.LoadLocation("Europe/Berlin")

// TibiaDataDatetime func
func TibiaDataDatetime(date string) string {
//TODO: Normalization needs to happen above this layer
Expand All @@ -31,14 +34,11 @@ func TibiaDataDatetime(date string) string {
// The string that should be returned is the current timestamp
returnDate = time.Now()
} else {
// timezone use in html: CET/CEST
loc, _ := time.LoadLocation("Europe/Berlin")

// format used in datetime on html: Jan 02 2007, 19:20:30 CET
formatting := "Jan 02 2006, 15:04:05 MST"

// parsing html in time with location set in loc
returnDate, err = time.ParseInLocation(formatting, date, loc)
returnDate, err = time.ParseInLocation(formatting, date, berlinLocation)

// parsing html in tiem without loc
//returnDate, err = time.Parse("Jan 02 2006, 15:04:05 MST", date)
Expand Down
Loading