LOOP-4665 Functional Algorithm#594
Merged
Merged
Conversation
Tidepool sync
Fix predicted BG graph only showing sometimes
…pectiveCorrectionSelectionView ✏️ Fix a typo in IntegralRetrospectiveCorrectionSelectionView
Updated translations from Lokalise on Sat Aug 19 14:25:48 CDT 2023
Override warning fix
Fixed numeral localization in insulin delivery table view
…nore-calibration Disable missed meal detection if there are user-entered or calibration BGs
…reamline app startup when running app just for tests
Functional loop algorithm
…failing with the optimization
Camji55
approved these changes
Sep 7, 2023
| let descriptionWithFont = String(format:"<style>body{font-family: '-apple-system', '\(font.fontName)'; font-size: \(font.pointSize);}</style>%@", description) | ||
|
|
||
| guard let attributedDescription = try? NSMutableAttributedString(data: Data(descriptionWithFont.utf8), options: [.documentType: NSAttributedString.DocumentType.html], documentAttributes: nil) else { | ||
| guard let attributedDescription = try? NSMutableAttributedString(data: descriptionWithFont.data(using: .utf16)!, options: [.documentType: NSAttributedString.DocumentType.html], documentAttributes: nil) else { |
Author
There was a problem hiding this comment.
I believe we are creating all the strings that go in there; it's not user data, so I think yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-4665
Contains tests that assert that the new functional algorithm added in tidepool-org/LoopKit#542
(see
testLiveCaptureWithFunctionalAlgorithm) produces the same output as LoopDataManager (seetestForecastFromLiveCaptureInputData())Other changes included: