[PAL-818] allow direction of when a plugin is a dependency#623
Merged
Conversation
nhamming
force-pushed
the
nate/PAL-818/deleting-service
branch
from
0e9eac4 to
11adbf3
Compare
nhamming
force-pushed
the
nate/PAL-818/deleting-service
branch
from
11adbf3 to
7a87f8b
Compare
ps2
requested changes
Oct 30, 2024
ps2
left a comment
ps2
left a comment
There was a problem hiding this comment.
A method name with a prefix of is isDependency is usually a getter to ask a question. This appears to be a setter, so maybe setDependency, or markAsDepedency?
This was referenced Oct 30, 2024
This was referenced Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/PAL-818