Skip to content

LOOP-340 Integrate latest TidepoolKit into TidepoolService (part 2)#6

Merged
darinkrauss merged 6 commits into
devfrom
darinkrauss/LOOP-340-integrate-latest-tidepoolkit
Apr 22, 2020
Merged

LOOP-340 Integrate latest TidepoolKit into TidepoolService (part 2)#6
darinkrauss merged 6 commits into
devfrom
darinkrauss/LOOP-340-integrate-latest-tidepoolkit

Conversation

@darinkrauss
Copy link
Copy Markdown
Contributor

@darinkrauss darinkrauss commented Apr 21, 2020

  • https://tidepool.atlassian.net/browse/LOOP-340
  • Refactor login workflow to get or create data set while logging in, not afterwards
  • Correctly include TidepoolKit and TidepoolKitUI frameworks in build
  • Update Cartfile to use latest LoopKit and TidepoolKit
  • Update .gitignore to filter entire Carthage directory

Darin Krauss added 2 commits April 19, 2020 14:44
- Refactor login workflow to get or create data set while logging in, not afterwards
- Correctly include TidepoolKit and TidepoolKitUI frameworks in build
- Update Cartfile to use latest LoopKit and TidepoolKit
- Update .gitignore to filter entire Carthage directory
Copy link
Copy Markdown
Contributor

@nhamming nhamming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rickpasetto rickpasetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@nhamming nhamming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rickpasetto rickpasetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darinkrauss darinkrauss merged commit 88720e3 into dev Apr 22, 2020
@darinkrauss darinkrauss deleted the darinkrauss/LOOP-340-integrate-latest-tidepoolkit branch April 22, 2020 21:32
ps2 added a commit that referenced this pull request Apr 21, 2023
Upload automation status for temp and normal basals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants