Add oura periodic and personal work processors#951
Open
darinkrauss wants to merge 1 commit into
Open
Conversation
Contributor
darinkrauss
commented
May 18, 2026
- Add oura periodic and personal work processors
- Update tests
- https://tidepool.atlassian.net/browse/BACK-4443
- https://tidepool.atlassian.net/browse/BACK-4447
- Add oura periodic and personal work processors - Update tests - https://tidepool.atlassian.net/browse/BACK-4443 - https://tidepool.atlassian.net/browse/BACK-4447
There was a problem hiding this comment.
Pull request overview
This PR extends the Oura integration’s background ingestion by introducing two new work processors—periodic (recurring incremental pulls for selected data types) and personal (personal_info with hash-based de-dupe)—and wires them into setup + service initialization so they run automatically after an Oura account is connected.
Changes:
- Add new Oura work processor implementations + factories for
oura/data/work/periodicandoura/data/work/personal, including comprehensive unit tests. - Update Oura user setup work to enqueue the new periodic + personal work items after setup.
- Register the new processor factories in the data service’s standard initialization.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| work/base/processor_test.go | Tightens gomock expectations to assert non-nil ctx/time args. |
| oura/user/work/setup/processor.go | Enqueues periodic + personal data work after successful Oura setup. |
| oura/user/work/setup/processor_test.go | Extends setup tests to cover periodic/personal work creation paths. |
| oura/data/work/personal/test/processor.go | Adds test helpers for personal work metadata/object serialization. |
| oura/data/work/personal/processor.go | Implements personal_info ingestion with scope gating + hash-based skip. |
| oura/data/work/personal/processor_test.go | Adds unit tests for personal processor behavior and metadata validation. |
| oura/data/work/personal/personal_suite_test.go | Adds Ginkgo suite bootstrap for personal package tests. |
| oura/data/work/personal/factory.go | Adds processor factory + work.Create builder for personal work. |
| oura/data/work/personal/factory_test.go | Adds tests for personal factory and work.Create construction. |
| oura/data/work/periodic/test/processor.go | Adds test helpers for periodic work metadata/object serialization. |
| oura/data/work/periodic/processor.go | Implements periodic ingestion with per-datatype start times + pagination tokens. |
| oura/data/work/periodic/processor_test.go | Adds unit tests covering periodic paging, metadata updates, and failures. |
| oura/data/work/periodic/periodic_suite_test.go | Adds Ginkgo suite bootstrap for periodic package tests. |
| oura/data/work/periodic/factory.go | Adds processor factory + work.Create builder for periodic work. |
| oura/data/work/periodic/factory_test.go | Adds tests for periodic factory and work.Create construction. |
| data/service/service/standard.go | Registers periodic/personal processor factories during service init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toddkazakov
approved these changes
May 21, 2026
Contributor
toddkazakov
left a comment
There was a problem hiding this comment.
Nothing blocking, just one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.