Skip to content

Add unsigned retry for commit signing failures#6

Open
tim-smart wants to merge 5 commits into
t3code/add-direnv-shell-supportfrom
t3code/git-signing-toggle
Open

Add unsigned retry for commit signing failures#6
tim-smart wants to merge 5 commits into
t3code/add-direnv-shell-supportfrom
t3code/git-signing-toggle

Conversation

@tim-smart

Copy link
Copy Markdown
Owner

Summary

  • Detect commit signing failures and expose a one-time unsigned retry for web and mobile Git actions.
  • Preserve feature-branch state during retries and pass --no-gpg-sign only for the retried commit.
  • Improve commit hook progress ordering and output attribution while avoiding leaked signing diagnostics.
  • Clear stale toast actions while Git operations are running.
  • Add contract, client-runtime, VCS, and Git manager coverage for signing failures and retry behavior.

Testing

  • Not run (PR content generated from the provided diff).
  • Added focused tests for signing-failure classification, unsigned commits, feature-branch retries, hook failures, progress ordering, and hook-output attribution.

@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch 3 times, most recently from 1ebb4e4 to 82558fc Compare July 23, 2026 21:09
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 82558fc to 63e8682 Compare July 24, 2026 00:44
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch 2 times, most recently from c7907a7 to 90c665d Compare July 24, 2026 03:34
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Jul 24, 2026
@tim-smart
tim-smart changed the base branch from main to t3code/add-direnv-shell-support July 24, 2026 03:34
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 90c665d to d12869b Compare July 24, 2026 08:52
@github-actions github-actions Bot added size:L and removed size:XXL labels Jul 24, 2026
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from 1a7901d to d786974 Compare July 24, 2026 09:40
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from d12869b to 4479869 Compare July 24, 2026 09:40
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from d786974 to 41540af Compare July 24, 2026 14:12
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from 4479869 to 47379f1 Compare July 24, 2026 14:12
- Detect commit signing failures across server and client
- Let stacked git actions retry once with signing disabled
- Preserve unsigned commit behavior in commit, push, and PR flows
- Prevent stale action controls from appearing on Git progress toasts
@tim-smart
tim-smart force-pushed the t3code/add-direnv-shell-support branch from 41540af to 8f5fc87 Compare July 25, 2026 10:26
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 47379f1 to 7d65c5a Compare July 25, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant