multiple reviewers should be space separation.

[jetersen]

github-comment-ops/index.js

Line 121 in 26bc7b9

const reviewersToBeParsed = reviewerMatches[1].split(",");

@timja this should potentially handle spaces instead of comma separation.

One they cannot have spaces in their username.
Two by default the auto complete fills in a space when hitting enter for completion.

@timja @jetersen @etc

[lemeurherve]

I'd still keep the comma to be coherent with the /label command with a comma separator accepting labels with spaces

[jetersen]

Should be relatively easy

Believe you can do

const reviewersToBeParsed = reviewerMatches[1].split("[, ]");

[jetersen]

I'd suggest writing some tests 😉

updatecli/updatecli-action#100

[timja]

It's next on my plan 😄
I've done some refactoring recently to make them easier to implement

#7

---

and yes makes sense to allow spaces here and I agree with @lemeurherve that comma should be kept for consistency with labels which can't have a space separator

[timja]

Should be relatively easy

Believe you can do

const reviewersToBeParsed = reviewerMatches[1].split("[, ]");

The tests failed with this, I just did:

  const separator = reviewers.includes(",") ? "," : " ";
  const split = reviewers.split(separator);

[jetersen]

@timja

The correct syntax is /regex/ by bad :D

const split = reviewers.split(/[,\s]/);

[timja]

sure not sure if I really want to support both at the same time anyway, so my approach should be fine?

[jetersen]

Why not regex can handle splitting correctly for both? 😅

[timja]

yeah sure have merged