Skip to content

Add eslint and fix eslint issues#55

Merged
timja merged 3 commits intotimja:mainfrom
jetersen:add/eslint
Jul 25, 2022
Merged

Add eslint and fix eslint issues#55
timja merged 3 commits intotimja:mainfrom
jetersen:add/eslint

Conversation

@jetersen
Copy link
Copy Markdown
Contributor

fixes #46

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the chore label Jul 25, 2022
@timja
Copy link
Copy Markdown
Owner

timja commented Jul 25, 2022

lint issues

"lint": "prettier --check .",
"lint:fix": "prettier --write ."
"lint": "eslint .",
"lint:fix": "eslint --fix ."
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make it so you don't need to invoke prettier at all? i.e. the plugin will do prettier under the hood?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however this only applies to js files 😅

So potentially you want it for other files

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57

@timja
Copy link
Copy Markdown
Owner

timja commented Jul 25, 2022

Thanks!

@timja timja changed the title add eslint and fix eslint issues Add eslint and fix eslint issues Jul 25, 2022
@timja timja merged commit 00fbd39 into timja:main Jul 25, 2022
@jetersen jetersen deleted the add/eslint branch July 25, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add eslint

3 participants