Skip to content

Config based approach to commands#60

Merged
timja merged 17 commits intomainfrom
config-based-approach-to-commands
Jul 29, 2022
Merged

Config based approach to commands#60
timja merged 17 commits intomainfrom
config-based-approach-to-commands

Conversation

@timja
Copy link
Copy Markdown
Owner

@timja timja commented Jul 26, 2022 •
edited
Loading

Fixes #54
Fixes #33
Fixes #56

Introduces configuration to allow enabling and disabling of commands
This is the basis that permissions will be added on top of.

@timja timja mentioned this pull request Jul 26, 2022
Closed
jetersen
jetersen reviewed Jul 26, 2022
View reviewed changes
jetersen
jetersen reviewed Jul 26, 2022
View reviewed changes
jetersen
jetersen reviewed Jul 26, 2022
View reviewed changes
@timja
Copy link
Copy Markdown
Owner Author

timja commented Jul 27, 2022

Config based approach seems to be working good, tested at org level and repo level, it doesn't do any merging by default but i've added some in after trying a few different approaches

@lemeurherve lemeurherve mentioned this pull request Jul 27, 2022
Open
jetersen
jetersen reviewed Jul 27, 2022
View reviewed changes
jetersen
jetersen reviewed Jul 27, 2022
View reviewed changes
timja and others added 4 commits July 27, 2022 19:40
jetersen
jetersen reviewed Jul 28, 2022
View reviewed changes
jetersen
jetersen reviewed Jul 28, 2022
View reviewed changes
@timja timja added the enhancement New feature or request label Jul 29, 2022
jetersen
jetersen reviewed Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jetersen jetersen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far, a few linter errors and we are almost there! 👏

jetersen
jetersen reviewed Jul 29, 2022
View reviewed changes
@timja @jetersen
Update app/commands.js
1c7c419 
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
jetersen
jetersen reviewed Jul 29, 2022
View reviewed changes
@timja timja mentioned this pull request Jul 29, 2022
Open
@timja timja marked this pull request as ready for review July 29, 2022 13:39
@timja timja enabled auto-merge (squash) July 29, 2022 13:40
@timja timja merged commit cab2070 into main Jul 29, 2022
@timja timja deleted the config-based-approach-to-commands branch July 29, 2022 13:40
@timja timja mentioned this pull request Jul 29, 2022
Closed
@jetersen
Copy link
Copy Markdown
Contributor

jetersen commented Jul 29, 2022

@timja great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jetersen jetersen jetersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: protected labels Provide an "opt-out" at repository level

2 participants

@timja @jetersen