Conversation
…ix task SeedTemplates.run() calls System.halt(1) on failure, which kills the migration process. Use Templates.seed_system_templates() directly (same approach as V31) so validation failures are logged gracefully without aborting the migration.
…plates Mix task" This reverts commit 773a777.
System.halt(1) kills the entire VM when called from migrations (V15 calls SeedTemplates.run() and has a try/rescue wrapper, but System.halt bypasses all rescue handlers). Raising an exception instead allows migration rescue blocks to handle the failure gracefully.
Fix SeedTemplates: raise exception instead of System.halt on failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dev branch including fix for SeedTemplates System.halt issue in migrations.