Skip to content

Refactor small piece of injection. #44

@nearestnabors

Description

@nearestnabors

Hey Potch. I took care of all this over the weekend.

But there's some cleanup I need your help with. To get my changes in ending.js to work, I had to move the following outside the IFFE statement in main.js:

`var dashboardOpen = false;
// opening and closing panels in the dashboard
// track open or closed

var moveDashboard = function(panel) {
var $dashBoardHeight = $("#menu_options").outerHeight() + panel.outerHeight();
$("#control-panel").css({ transform: 'translateY(calc(100% - ' + $dashBoardHeight + 'px))'});
}`

Could you make that less gross: move it back into the IFFE or at least to the top of main.js. And tell me how/why so I can do it better next time!

Thanks!

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions