Remove pkg-resources from list of quick-install requirements - #1032
Merged
Conversation
According to this thread, this line was always erroneous and we should just remove it: pypa/pip#4022 Fixes #1031 Fixes #1015
jdeanwallace
approved these changes
Jun 28, 2022
jdeanwallace
left a comment
jdeanwallace
left a comment
Contributor
There was a problem hiding this comment.
Looks good
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
quick-install line 159 at r1 (raw file):
Jinja2==2.11.2 MarkupSafe==1.1.1 pkg-resources==0.0.0
Do we also want to remove pkg-resources from the bundler's pip requirements.txt file?
mtlynch
commented
Jun 28, 2022
mtlynch
left a comment
mtlynch
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewable status:
quick-install line 159 at r1 (raw file):
Previously, jdeanwallace (Jason Wallace) wrote…
Do we also want to remove
pkg-resourcesfrom the bundler's piprequirements.txtfile?
Ah, right. Fixed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this thread, this line was always erroneous and we should just remove it: pypa/pip#4022
It doesn't seem to harm anything on Raspberry Pi OS, but it causes problems on other distros.
Fixes #1031
Fixes #1015
This change is