Prevent installation on Bookworm - #1671
Merged
Merged
Conversation
mtlynch
previously requested changes
Nov 1, 2023
mtlynch
left a comment
mtlynch
left a comment
Contributor
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM, thanks!
In: bundler/bundle/install:
> Line 37
echo "You can track our progress by visiting https://github.com/tiny-pilot/tinypilot/issues/1668." >&2
Can we omit the trailing period? It's easier to copy/paste without it.
👀 @cghague it's your turn please take a look
cghague
commented
Nov 9, 2023
mtlynch
approved these changes
Nov 9, 2023
mtlynch
left a comment
mtlynch
left a comment
Contributor
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1667.
TinyPilot doesn't currently work on Raspberry Pi OS Bookworm, so this change adds a check to prevent installation on versions of Raspberry Pi OS newer than Bullseye. A link to the issue for adding Bookworm support is included in the error message for convenience. I've tested this on-device on both Bullseye and Bookworm.
