-
-
Notifications
You must be signed in to change notification settings - Fork 243
New Crowdin updates #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #260
Changes from all commits
802667b
1d89624
8045084
116fcc0
71381b2
ac610db
e456dc6
a2e4b5f
732c018
7d1f443
a340eb3
2ccd59b
a56d43a
4e89285
e9ddfe9
7fb436b
a0cf2e9
cbd4b1f
ce86bbb
bbed4ff
8716a78
268be82
89ee073
019aa87
b21c386
43779df
dd17627
d0e0e53
1cc5033
89511b1
a598482
481125a
e3cfd80
4100097
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |
| "forgotPasswordTitle": "نسيت كلمة المرور؟", | ||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||
| "errorTitle": "حدث خطأ", | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
| } | ||
|
Comment on lines
+53
to
55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Arabic locale contains an English-only string and potentially misleading admin-level instruction The value added for
Provide an Arabic translation and reconsider the wording (e.g., direct the user to contact an administrator) so the message is actionable for end users. 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |
| "forgotPasswordTitle": "Forgot your password?", | ||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||
| "errorTitle": "An error occurred", | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
|
Comment on lines
+53
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainUnify markup & avoid exposing internal implementation details
Diff suggestion: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Contact your administrator to reset your password (update <code>USERS</code> in the server configuration)."Ensure the same fix is applied across all locale JSON files added in this PR. 🏁 Script executed: #!/bin/bash
set -e
echo "Locale files containing forgotPasswordMessage:"
rg '"forgotPasswordMessage"' -l frontend/src/lib/i18n/locales
echo
echo "en-US.json snippet around forgotPasswordMessage:"
rg -n '"forgotPasswordMessage"' -A2 frontend/src/lib/i18n/locales/en-US.json
echo
echo "All occurrences of <code> tags in locale JSON files:"
rg '<code>' -n frontend/src/lib/i18n/localesLength of output: 49603 Unify inline code markup & remove internal details from forgotPasswordMessage The surrounding locale strings use HTML • Locate every JSON under Diff for each file: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Contact your administrator to reset your password (update <code>USERS</code> in the server configuration)."🤖 Prompt for AI Agents |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |
| "forgotPasswordTitle": "Glemt din adgangskode?", | ||
| "failedToFetchProvidersTitle": "Kunne ikke indlæse godkendelsesudbydere. Tjek venligst din konfiguration.", | ||
| "errorTitle": "Der opstod en fejl", | ||
| "errorSubtitle": "Der opstod en fejl under forsøget på at udføre denne handling. Tjek venligst konsollen for mere information." | ||
| "errorSubtitle": "Der opstod en fejl under forsøget på at udføre denne handling. Tjek venligst konsollen for mere information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
|
Comment on lines
+53
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. String is English and exposes backend detail—replace with a proper Danish, user-appropriate message The new entry is (a) not localized, and (b) tells users to edit the 🤖 Prompt for AI Agents |
||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||
| "forgotPasswordTitle": "Passwort vergessen?", | ||||||
| "failedToFetchProvidersTitle": "Fehler beim Laden der Authentifizierungsanbieter. Bitte überprüfen Sie Ihre Konfiguration.", | ||||||
| "errorTitle": "Ein Fehler ist aufgetreten", | ||||||
| "errorSubtitle": "Beim Versuch, diese Aktion auszuführen, ist ein Fehler aufgetreten. Bitte überprüfen Sie die Konsole für weitere Informationen." | ||||||
| "errorSubtitle": "Beim Versuch, diese Aktion auszuführen, ist ein Fehler aufgetreten. Bitte überprüfen Sie die Konsole für weitere Informationen.", | ||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion String is not localized & markup style deviates from the rest of the file The value is still in English, while every other entry in this file is German. - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Sie können Ihr Passwort zurücksetzen, indem Sie die Umgebungsvariable <code>USERS</code> anpassen."📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||||||
| "forgotPasswordTitle": "¿Olvidó su contraseña?", | ||||||||||
| "failedToFetchProvidersTitle": "Error al cargar los proveedores de autenticación. Por favor revise su configuración.", | ||||||||||
| "errorTitle": "Ha ocurrido un error", | ||||||||||
| "errorSubtitle": "Ocurrió un error mientras se trataba de realizar esta acción. Por favor, revise la consola para más información." | ||||||||||
| "errorSubtitle": "Ocurrió un error mientras se trataba de realizar esta acción. Por favor, revise la consola para más información.", | ||||||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||||||
|
Comment on lines
+53
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Message is still in English & markup style diverges from the rest of the file The value for - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Puede restablecer su contraseña cambiando la variable de entorno <code>USERS</code>."📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||||||
| "forgotPasswordTitle": "Forgot your password?", | ||||||||||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||||||||||
| "errorTitle": "An error occurred", | ||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||||||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||||||
|
Comment on lines
+53
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent ❓ Verification inconclusiveEnglish string & inconsistent markup in Finnish locale – supply proper translation and The value is English in a Finnish file and uses Markdown back-ticks, whereas the rest of the file consistently wraps technical tokens with - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Voit nollata salasanasi muuttamalla <code>USERS</code>-ympäristömuuttujaa."Please confirm the wording with your translators and keep the Replace English text and inconsistent markup in Finnish locale The - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Voit nollata salasanasi muuttamalla <code>USERS</code>-ympäristömuuttujaa."• Confirm the Finnish phrasing with your translators. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||||||
| "forgotPasswordTitle": "Forgot your password?", | ||||||||||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||||||||||
| "errorTitle": "An error occurred", | ||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||||||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||||||
|
Comment on lines
+53
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainString is untranslated & formatting inconsistent with existing conventions The newly-added value remains in English and uses back-tick markdown, whereas the rest of the file consistently translates content to Italian and wraps code tokens with Suggested fix: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Puoi reimpostare la password modificando la variabile di ambiente <code>USERS</code>."Please also ensure the same adjustment is applied (translated + 🏁 Script executed: #!/bin/bash
# List JSON locale files
echo "Locale JSON files:"
find frontend/src/lib/i18n/locales -type f -name '*.json'
# Find occurrences of forgotPasswordMessage
echo -e "\nOccurrences of forgotPasswordMessage:"
rg -n '"forgotPasswordMessage":' -n frontend/src/lib/i18n/locales
# Excerpt around the key in Italian locale
echo -e "\nExcerpt around forgotPasswordMessage in it-IT.json:"
rg -n '"forgotPasswordMessage":' -A2 -n frontend/src/lib/i18n/locales/it-IT.json
# Display lines containing <code> tags in Italian locale
echo -e "\nLines with <code> tags in it-IT.json:"
rg -n '<code>' -n frontend/src/lib/i18n/locales/it-IT.jsonLength of output: 7695 Translate The Affected files (non-English locales under Example diff for Italian ( - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Puoi reimpostare la password modificando la variabile di ambiente <code>USERS</code>."Please update each non-English locale entry with the correct translation and wrap 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |
| "forgotPasswordTitle": "Forgot your password?", | ||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||
| "errorTitle": "An error occurred", | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaking internal deployment details to end-users - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "パスワードを忘れた場合は、管理者にお問い合わせください。"🤖 Prompt for AI Agents💡 Verification agent 🧩 Analysis chainVerify that every locale file now contains the new key 🏁 Script executed: #!/bin/bash
# Check all locale files for the new key and report any missing ones
fd -e json forgotPasswordMessage frontend/src/lib/i18n/locales | \
xargs -I{} bash -c 'grep -q "\"forgotPasswordMessage\"" "{}" || echo "MISSING: {}"'Length of output: 152 Let’s correct the approach and explicitly scan every locale file for the key: 🏁 Script executed: #!/bin/bash
# List any locale JSON files missing the "forgotPasswordMessage" key
grep -R '"forgotPasswordMessage"' frontend/src/lib/i18n/locales -L --include '*.json'Length of output: 125 Missing The new • Frontend/src/lib/i18n/locales/en.json Suggested diff: --- a/frontend/src/lib/i18n/locales/en.json
+++ b/frontend/src/lib/i18n/locales/en.json
@@ {
"forgotUsername": "If you forgot your username, contact support.",
+ "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
}
🤖 Prompt for AI Agents |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |
| "forgotPasswordTitle": "Forgot your password?", | ||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||
| "errorTitle": "An error occurred", | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
| } | ||
|
Comment on lines
+53
to
55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainString is not localized and breaks locale consistency The new value is still in English, while every other entry in this file is Norwegian. This will surface an English-only string in a Norwegian UI and confuse users. Example quick fix: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Du kan tilbakestille passordet ditt ved å endre miljøvariabelen `USERS`."Confirm that the other locale files received a translated value as well; if not, create separate keys (e.g., “forgotPasswordMessage_en”) or mark them for translation in Crowdin. 🏁 Script executed: #!/bin/bash
# Search for the key across all locale files to verify translations
rg -n '"forgotPasswordMessage"' frontend/src/lib/i18n/localesLength of output: 4533 Fix missing translations for The Affected files:
Example quick fix for Norwegian (no-NO.json): - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Du kan tilbakestille passordet ditt ved å endre miljøvariabelen `USERS`."For other locales, either:
"forgotPasswordMessage": "TODO – needs translation"so that these keys are flagged for translation in Crowdin. 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||||||||||
| "forgotPasswordTitle": "Forgot your password?", | ||||||||||||||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||||||||||||||
| "errorTitle": "An error occurred", | ||||||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||||||||||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||||||||||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||||||||||
| } | ||||||||||||||
|
Comment on lines
+53
to
55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Message remains in English in a Portuguese locale – please provide a proper translation - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Pode redefinir a sua palavra-passe alterando a variável de ambiente <code>USERS</code>."(Adjust wording as appropriate.) 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,5 +50,6 @@ | |||||
| "forgotPasswordTitle": "Forgot your password?", | ||||||
| "failedToFetchProvidersTitle": "Failed to load authentication providers. Please check your configuration.", | ||||||
| "errorTitle": "An error occurred", | ||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information." | ||||||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||||||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent ❓ Verification inconclusiveMessage is English, leaks internals, and is unsuitable for end-users
Consider one of these approaches: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Contactați administratorul pentru resetarea parolei."If the intent really is to address administrators, move the string to an admin-only locale file or gate its usage in UI logic. Translate and remove internal env var reference in This string is currently in English, exposes an internal • File: Suggested fix: - "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable."
+ "forgotPasswordMessage": "Contactați administratorul pentru resetarea parolei."If this message is truly meant for administrators rather than end-users, consider moving it into an admin-specific locale file or gating it behind admin-only UI logic. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Avoid leaking internal implementation details & provide a user-appropriate message
The string instructs users to modify the
USERSenvironment variable—knowledge an end-user typically doesn’t have, and which may reveal internal configuration details. This is both confusing (Afrikaans users receive an English technical message) and potentially a security concern.Consider rephrasing to a generic, user-friendly instruction (and translating it to Afrikaans), e.g.:
Apply the same change across all locale files to maintain consistency.
🏁 Script executed:
Length of output: 6005
Replace technical instruction with a user-friendly, localized message
The
forgotPasswordMessagestring appears unchanged in all locale files underfrontend/src/lib/i18n/locales/*.json. Instructing end users to modify an internalUSERSenvironment variable leaks implementation details and isn’t user-appropriate. Please update this key in every locale to a generic, localised instruction. For example, inaf-ZA.json:• Apply equivalent, correctly translated messages in each of:
Ensure each value is translated appropriately.
📝 Committable suggestion
🤖 Prompt for AI Agents